-
Notifications
You must be signed in to change notification settings - Fork 178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HTML Body PostProcessor (integrating PreMailer) #81
base: master
Are you sure you want to change the base?
Conversation
Thanks for this. I'll probably need a bit if time to look at this, but I Sent from my iPhone On 2013-02-02, at 10:52 AM, Hernan Marano notifications@github.com wrote: The best bet to styling html emails is to set the style attribute in the So I have modified mvc.mailer so html body is passed through a list of I followed the preprocessor pattern of SquishIt library. I hope this You've done a great job with Mvc.Mailer. I am using it in several projects. Thanks guys!You can merge this Pull Request by running git pull https://github.com/hernangm/MvcMailer master Or view, comment on, or merge it at: #81
File Changes
Patch Links: |
Don't worry, take ur time. |
Bump. Cheers:D |
Is this dead? |
The best bet to styling html emails is to set the style attribute in the corresponding tags. However, most people usually have their style definitions in separate css files. There is plenty of documentation about this on the web (http://css-tricks.com/using-css-in-html-emails-the-real-story/).
So I have modified mvc.mailer so html body is passed through a list of configured post processors. One of this post-processor (based on the premailer library) removes style definition from the head tag and apply the rules to the corresponding tags in the body.
I followed the preprocessor pattern of SquishIt library. I hope this modification gets integrated to the master branch.
You've done a great job with Mvc.Mailer. I am using it in several projects. Thanks guys!